Skip to content

FINERACT-1257: Year end retaining earning job#5986

Merged
adamsaghy merged 3 commits into
apache:developfrom
openMF:FINERACT-1257/year-end-retaining-earning
Jun 17, 2026
Merged

FINERACT-1257: Year end retaining earning job#5986
adamsaghy merged 3 commits into
apache:developfrom
openMF:FINERACT-1257/year-end-retaining-earning

Conversation

@Cocoa-Puffs

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Cocoa-Puffs Cocoa-Puffs changed the title Fineract 1257/year end retaining earning FINERACT-1257: Year end retaining earning job Jun 15, 2026
@Cocoa-Puffs Cocoa-Puffs force-pushed the FINERACT-1257/year-end-retaining-earning branch 2 times, most recently from 76e95dd to 097574b Compare June 15, 2026 10:23
@Cocoa-Puffs

Copy link
Copy Markdown
Contributor Author

the fineract build failed with the following deprecation warning:

* What went wrong:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
Execution failed for task ':fineract-provider:compileJava'.
> Compilation failed; see the compiler output below.
  /home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/migration/TenantDatabaseUpgradeService.java:91: warning: [deprecation] ThreadLocalScopeManager in liquibase has been deprecated
              Scope.setScopeManager(new ThreadLocalScopeManager());

I have looked up the liquibase documentation to find out why this is deprecated and what is the recommended upgrade path. https://javadocs.liquibase.com/liquibase-core/liquibase/ThreadLocalScopeManager.html

According to the docs of this file "ScopeManager now uses ThreadLocal to prevent concurrent modification issues. This class is no longer needed." So i have removed the setting in our upgrade service.

@Cocoa-Puffs Cocoa-Puffs force-pushed the FINERACT-1257/year-end-retaining-earning branch from 097574b to 78df465 Compare June 15, 2026 10:47
@adamsaghy

Copy link
Copy Markdown
Contributor

the fineract build failed with the following deprecation warning:

* What went wrong:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
Execution failed for task ':fineract-provider:compileJava'.
> Compilation failed; see the compiler output below.
  /home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/migration/TenantDatabaseUpgradeService.java:91: warning: [deprecation] ThreadLocalScopeManager in liquibase has been deprecated
              Scope.setScopeManager(new ThreadLocalScopeManager());

I have looked up the liquibase documentation to find out why this is deprecated and what is the recommended upgrade path. https://javadocs.liquibase.com/liquibase-core/liquibase/ThreadLocalScopeManager.html

According to the docs of this file "ScopeManager now uses ThreadLocal to prevent concurrent modification issues. This class is no longer needed." So i have removed the setting in our upgrade service.

Have we changed liquibase version? i wonder what changed

@Cocoa-Puffs Cocoa-Puffs force-pushed the FINERACT-1257/year-end-retaining-earning branch 3 times, most recently from 51ef9f2 to 09f6ff2 Compare June 15, 2026 13:42

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cocoa-Puffs Kindly asking you to review my concerns.

@Cocoa-Puffs Cocoa-Puffs force-pushed the FINERACT-1257/year-end-retaining-earning branch from a020466 to 41b7131 Compare June 16, 2026 13:18

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cocoa-Puffs Cocoa-Puffs force-pushed the FINERACT-1257/year-end-retaining-earning branch from 41b7131 to c9f6a5f Compare June 17, 2026 07:34
@adamsaghy adamsaghy merged commit b8e5088 into apache:develop Jun 17, 2026
90 checks passed
@adamsaghy adamsaghy deleted the FINERACT-1257/year-end-retaining-earning branch June 17, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants