HDDS-16408. Prevent DeletePublicAccessBlock from deleting buckets - #11236
Open
F64116045 wants to merge 1 commit into
Open
HDDS-16408. Prevent DeletePublicAccessBlock from deleting buckets#11236F64116045 wants to merge 1 commit into
F64116045 wants to merge 1 commit into
Conversation
F64116045
marked this pull request as ready for review
September 13, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
S3 Gateway does not recognize the
publicAccessBlockquery parameter. As a result,DELETE /{bucket}?publicAccessBlockis routed toDeleteBucketand deletes an empty bucket.Ozone does not support Public Access Block yet, but this request should not delete the bucket. This change excludes
publicAccessBlockrequests from the regular bucket deletion path, so the request returns501 NotImplementedand the bucket remains unchanged.The Public Access Block compatibility test will still fail until the feature is implemented. This change fixes the unsafe request routing; full Public Access Block support can be handled separately.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16408
How was this patch tested?
mvn -pl hadoop-ozone/s3gateway \ -Dtest=TestBucketDelete testmvn -pl hadoop-ozone/integration-test-s3 -am \ -DskipDocs -DskipShade -Dskip.npm \ -Dtest=TestS3SDK \ -Dsurefire.failIfNoSpecifiedTests=false testCI: https://github.com/F64116045/ozone/actions/runs/34764029942