Reject submitted jar locations that are not inside the Nimbus inbox - #8980
Open
rzo1 wants to merge 1 commit into
Open
Reject submitted jar locations that are not inside the Nimbus inbox#8980rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
submitTopologyWithOptsvalidated the topology name, conf, blobstore map, worker heap and structure, but never theuploadedJarLocationit passes tosetupStormCode, so any path readable by Nimbus was opened and copied into the topology jar blob.The location is now canonicalised and must resolve strictly inside
ServerConfigUtils.masterInbox. Local mode is unaffected, sinceLocalClusterpasses null. ExtendsNimbusTest.