Give each uploaded dependency artifact its own blob key instead of reusing a pre-existing blob - #8982
Open
rzo1 wants to merge 1 commit into
Open
Give each uploaded dependency artifact its own blob key instead of reusing a pre-existing blob#8982rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
…using a pre-existing blob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency artifacts were stored under a key derived only from the artifact coordinate, shared by every submitter, and
KeyAlreadyExistsExceptionwas swallowed with the comment "we lose the race, but it does not matter", so an existing blob under that key was accepted as the artifact without any check on its contents.Keys now carry a UUID, matching what
uploadFiles()already does. Note this means dependency blobs are no longer shared between submissions, so repeated submissions upload their dependencies again. ExtendsDependencyUploaderTest.