chore(frontend): remove two commented-out test blocks from the workflow editor spec - #8465
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(frontend): remove two commented-out test blocks from the workflow editor spec#8465aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8465 +/- ##
=========================================
Coverage 93.94% 93.94%
Complexity 4826 4826
=========================================
Files 1209 1209
Lines 49705 49705
Branches 6074 6074
=========================================
Hits 46694 46694
Misses 1522 1522
Partials 1489 1489
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes two large commented-out test blocks from
workflow-editor.component.spec.ts. Neither can be re-enabled as written, and both have live replacement coverage. Pure deletion, no behaviour change: −225 lines.History
describe("clipboard")block in this same file covers all three cases (copy, cut, paste), and the paste-offset property is covered inoperator-menu.service.spec.tsagainst the realfindNonOverlappingPositionlogicxdescribe("when executionStatus is enabled"))a9c404764a) — about six years. Cannot be revived: it spies onchangeOperatorStates/OperatorStates(plural) while the live code haschangeOperatorState/OperatorState(singular), and it callsTestBed.get, an API Angular has since removedNeither block is executable: re-parsing the file with the repo's own TypeScript finds zero live tokens in either range, so neither registers with Vitest and neither can appear in
junit.xmlor any skipped-test count.Any related issues, documentation, discussions?
Closes #8461
How was this PR tested?
Existing tests only — this PR removes commented text that runs nothing.
From
frontend/:npx ng test --watch=false --include='**/workflow-editor.component.spec.ts'— 106 tests pass, unchanged from before.yarn --cwd frontend format:ci— clean (this is the gate the blank-line handling protects).Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)