Skip to content

chore(frontend): remove two commented-out test blocks from the workflow editor spec - #8465

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/fe-commented-specs
Open

chore(frontend): remove two commented-out test blocks from the workflow editor spec#8465
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/fe-commented-specs

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes two large commented-out test blocks from workflow-editor.component.spec.ts. Neither can be re-enabled as written, and both have live replacement coverage. Pure deletion, no behaviour change: −225 lines.

History

Block 708-822 (copy/cut/paste) Commented out when written, by #1619 (2022-09-13, "Copy and Paste Operators with System Clipboard") — its header says the new clipboard path "would not pass this unit test, since write access to the system clipboard is needed". Superseded: the live describe("clipboard") block in this same file covers all three cases (copy, cut, paste), and the paste-offset property is covered in operator-menu.service.spec.ts against the real findNonOverlappingPosition logic
Block 531-638 (xdescribe("when executionStatus is enabled")) Commented out on 2020-08-01 (a9c404764a) — about six years. Cannot be revived: it spies on changeOperatorStates / OperatorStates (plural) while the live code has changeOperatorState / OperatorState (singular), and it calls TestBed.get, an API Angular has since removed

Neither block is executable: re-parsing the file with the repo's own TypeScript finds zero live tokens in either range, so neither registers with Vitest and neither can appear in junit.xml or any skipped-test count.

Reviewer note: the ranges were deleted bottom-up (708-823 first, then 531-639), each including its one trailing blank line. Line 707 and line 530 are already blank, so deleting only the comment ranges would leave doubled blank lines and fail yarn format:ci — confirmed empirically with prettier --check on both variants. The live describe("clipboard") block and the standing note about clipboard cases needing a real browser are kept.

Any related issues, documentation, discussions?

Closes #8461

How was this PR tested?

Existing tests only — this PR removes commented text that runs nothing.

From frontend/:

  • npx ng test --watch=false --include='**/workflow-editor.component.spec.ts' — 106 tests pass, unchanged from before.
  • yarn --cwd frontend format:ci — clean (this is the gate the blank-line handling protects).

Verification, re-runnable by a reviewer:

grep -c "xdescribe\|the new method of copying" frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts   # 0

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

Copilot AI lite review requested due to automatic review settings September 9, 2026 05:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @PG1204
    You can notify them by mentioning @PG1204 in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.94%. Comparing base (bda3400) to head (4f3959f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8465   +/-   ##
=========================================
  Coverage     93.94%   93.94%           
  Complexity     4826     4826           
=========================================
  Files          1209     1209           
  Lines         49705    49705           
  Branches       6074     6074           
=========================================
  Hits          46694    46694           
  Misses         1522     1522           
  Partials       1489     1489           
Flag Coverage Δ *Carryforward flag
access-control-service 80.18% <ø> (ø) Carriedforward from bda3400
agent-service 99.32% <ø> (ø) Carriedforward from bda3400
amber 89.91% <ø> (ø) Carriedforward from bda3400
computing-unit-managing-service 75.05% <ø> (ø) Carriedforward from bda3400
config-service 87.12% <ø> (ø) Carriedforward from bda3400
file-service 83.65% <ø> (ø) Carriedforward from bda3400
frontend 96.77% <ø> (ø)
notebook-migration-service 83.73% <ø> (ø) Carriedforward from bda3400
pyamber 98.47% <ø> (ø) Carriedforward from bda3400
workflow-compiling-service 77.19% <ø> (ø) Carriedforward from bda3400

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove two commented-out test blocks from the workflow editor spec

3 participants