feat(gui): read the schema's constraints in the property panel - #8507
Open
kz930 wants to merge 1 commit into
Open
feat(gui): read the schema's constraints in the property panel#8507kz930 wants to merge 1 commit into
kz930 wants to merge 1 commit into
Conversation
A column property is checked against the attribute type rule for every column it names rather than only the first. A hyperparameter's value renders as the control its parameter implies: a dropdown where the accepted set is known, a number input where it is numeric, a plain text box where the rules say nothing. A property declared unique among rows says which row already holds the value, and a row deleted clears the error it left behind. Split out of apache#8350 on review. That change is the export button; this one is a separate thread, and nothing in it makes a workflow exportable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8507 +/- ##
============================================
- Coverage 93.69% 93.68% -0.02%
Complexity 4826 4826
============================================
Files 1209 1210 +1
Lines 49871 49972 +101
Branches 6099 6133 +34
============================================
+ Hits 46727 46816 +89
- Misses 1652 1656 +4
- Partials 1492 1500 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
27 tasks
Contributor
Author
|
/request-review @aglinxinyuan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The property panel reads the constraints the schema declares.
A column property is checked against the attribute type rule for every column it names rather than only the first. A hyperparameter's value renders as the control its parameter implies: a dropdown where the accepted set is known, a number input where it is numeric, a plain text box where the rules say nothing. A property declared unique among rows says which row already holds the value, and a row deleted clears the error it left behind, since deleting a row changes no surviving control's value and the row left behind would otherwise keep an error about a duplicate that is no longer there.
#8350 is the export button; this one is a separate thread of work.
Any related issues, documentation, discussions?
Part of #8325, 26 of 27; that issue lists the set in order.
Closes #8510, the task this change is the whole of.
Supersedes #7983, #7980 and the frontend half of #7946, which are closed in favour of this. They touched the same three files, so reviewing them apart meant reading the same code more than once and resolving a conflict between them at merge.
Closes #7981. Part of #7979, #7952 and #7936, whose remaining half is in #8348; those three stay open until both land, since each is only fixed once the schema declares the rule and the panel enforces it.
How was this PR tested?
formly-utils.spec.tscovers the mapping from a declared rule to a control and the type checking across every named column.constrained-value.component.spec.tscovers what each control renders.operator-property-edit-frame.component.spec.tsdrives the rendered form, including the click that deletes a duplicate row and the error it has to clear.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
🤖 Generated with Claude Code