feat(frontend): filter console messages by type - #8515
Open
sshiv012 wants to merge 2 commits into
Open
Conversation
The console badges every message with its type but offers no way to act on it, so a UDF that prints per tuple buries a single ERROR under its output and the panel scrolls it out of view. Add a filter menu beside the settings gear holding a checkbox per type and a select-all, and a line above the list reporting how many messages are hidden. The gear keeps the display options it already had. Every type is visible by default, and a type the console has not seen before stays visible rather than being hidden by an unknown-type default. Both toolbar controls become buttons so the menus can be reached by keyboard, which the settings gear could not be as a bare anchor. They open on click and stay open while their options are used. Closes apache#8495 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016m8VBHFdnbBvNovMonAK9t
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8515 +/- ##
============================================
+ Coverage 93.63% 93.81% +0.18%
+ Complexity 4858 4812 -46
============================================
Files 1212 1208 -4
Lines 50037 49769 -268
Branches 6132 6088 -44
============================================
- Hits 46850 46691 -159
+ Misses 1675 1592 -83
+ Partials 1512 1486 -26
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The console badges every message with its type but offers no way to act on it. A Python UDF that prints per tuple buries a single ERROR under its output, and the panel auto-scrolls, pushing it out of view.
Adds a filter menu beside the settings gear: a checkbox per message type plus a select-all, and a line above the list reporting how many messages are hidden. The gear keeps the display options it already had.
Each filter option carries the same badge colour as the rows it controls. Every type is visible by default, and a type the console has not seen before stays visible rather than being hidden by an unknown-type default.
Both toolbar controls become buttons so the menus can be reached by keyboard — the settings gear could not be, as a bare
<a>with nohref. Verified by focusing the trigger and pressing Enter.Any related issues, documentation, discussions?
Closes #8495
How was this PR tested?
42 unit tests in
console-frame.component.spec.ts, up from 33 before this change.Verified live against a
1-out Python UDFemitting 23 PRINT messages, one ERROR, plus COMMAND and DEBUGGER from the debug console — unticking Print leaves the error alone at the top.The DOM tests were checked by mutation: swapping two checkbox bindings, and replacing the hidden-count interpolation with a literal, each fail a test.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
🤖 Generated with Claude Code
https://claude.ai/code/session_016m8VBHFdnbBvNovMonAK9t