Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The Angular notebook UI only supports exporting notes as
.zpln, while the classic UI also supports Jupyter notebook (.ipynb) export.This PR adds an
.ipynbexport button to the Angular notebook toolbar. It uses the existing server-side conversion protocol and adds the corresponding SDK message types. The two export buttons have distinct tooltips and accessible names.Existing
.zplnexport behavior is unchanged. Both buttons are hidden in report mode and disabled when viewing a revision.What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Run the following commands from
zeppelin-web-angular:With Zeppelin running at
http://localhost:8080, run:The export regression test verifies the downloaded notebook’s cells, Unicode content and filename, and absence of a UTF-8 BOM. It also checks that export still works without duplicate downloads after navigating away and reopening the note, and that
.zplnexport preserves the original note.For manual verification:
Screenshots (if appropriate)
Questions: