Repository navigation
[ZEPPELIN-6767] Stabilize last-page setup in table footer E2E test - #5602
Merged
voidmatcha merged 1 commit intoNov 1, 2026
Merged
Conversation
voidmatcha
approved these changes
Oct 31, 2026
voidmatcha
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
In a separate WebKit reproduction experiment with the focus-movement condition, the original Next click was lost in all 30 attempts, while clicking page 3 directly succeeded in all 30 attempts. The actual Linux WebKit E2E runs also passed without retries in both anonymous and authenticated modes.
These were not 30 full E2E runs, but this looks like an appropriate change to remove an unstable setup interaction while preserving the existing page and row assertions.
Member
|
Merged into master (606fc6c). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The table footer test verifies that the displayed rows and pagination stay synchronized after page-size and filter changes. It currently reaches the last page by clicking Next twice.
In WebKit, the second click can be lost when paragraph focus handling scrolls the page between mouse-down and mouse-up, leaving the test on page 2 before the behavior under test is exercised.
Select page 3 directly instead. Keep the assertions for the selected page and its exact rows, along with all subsequent page-size and filter assertions. This removes the unnecessary consecutive Next-click dependency without changing production focus behavior.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
With a Zeppelin backend running on localhost:8080, run from
zeppelin-web-angular:npm run e2e -- e2e/tests/notebook/paragraph/table-footer.spec.ts --grep "keeps page size and a filtered last page synchronized" --project=chromium --project=firefox --project=webkit --workers=1 --retries=0Repeat the affected WebKit scenario without retries:
npm run e2e -- e2e/tests/notebook/paragraph/table-footer.spec.ts --grep "keeps page size and a filtered last page synchronized" --project=webkit --workers=1 --repeat-each=5 --retries=0Questions: