Skip to content

[ZEPPELIN-6767] Stabilize last-page setup in table footer E2E test - #5602

Merged
voidmatcha merged 1 commit into
apache:masterfrom
miinhho:ZEPPELIN-6767-stabilize-table-footer
Nov 1, 2026
Merged

voidmatcha merged 1 commit into
apache:masterfrom
miinhho:ZEPPELIN-6767-stabilize-table-footer

Conversation

@miinhho

@miinhho miinhho commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What is this PR for?

The table footer test verifies that the displayed rows and pagination stay synchronized after page-size and filter changes. It currently reaches the last page by clicking Next twice.

In WebKit, the second click can be lost when paragraph focus handling scrolls the page between mouse-down and mouse-up, leaving the test on page 2 before the behavior under test is exercised.

Select page 3 directly instead. Keep the assertions for the selected page and its exact rows, along with all subsequent page-size and filter assertions. This removes the unnecessary consecutive Next-click dependency without changing production focus behavior.

What type of PR is it?

Improvement

Todos

  • Select the last page directly while preserving the existing assertions.

What is the Jira issue?

How should this be tested?

With a Zeppelin backend running on localhost:8080, run from zeppelin-web-angular:

npm run e2e -- e2e/tests/notebook/paragraph/table-footer.spec.ts --grep "keeps page size and a filtered last page synchronized" --project=chromium --project=firefox --project=webkit --workers=1 --retries=0

Repeat the affected WebKit scenario without retries:

npm run e2e -- e2e/tests/notebook/paragraph/table-footer.spec.ts --grep "keeps page size and a filtered last page synchronized" --project=webkit --workers=1 --repeat-each=5 --retries=0

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No; this change only adjusts an E2E test setup.

@voidmatcha voidmatcha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

In a separate WebKit reproduction experiment with the focus-movement condition, the original Next click was lost in all 30 attempts, while clicking page 3 directly succeeded in all 30 attempts. The actual Linux WebKit E2E runs also passed without retries in both anonymous and authenticated modes.

These were not 30 full E2E runs, but this looks like an appropriate change to remove an unstable setup interaction while preserving the existing page and row assertions.

@voidmatcha
voidmatcha merged commit 606fc6c into apache:master Nov 1, 2026
28 checks passed
@voidmatcha

Copy link
Copy Markdown
Member

Merged into master (606fc6c).

@miinhho
miinhho deleted the ZEPPELIN-6767-stabilize-table-footer branch November 1, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants