Skip to content

feat(push): print Standby URL when actor.json.usesStandbyMode is true #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DaveHanns wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(push): print Standby URL when actor.json.usesStandbyMode is true #1259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/commands/actors/push.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const BUILD_LOG_TAIL_LINES = 10;
interface PushResult {
ok: boolean;
operation: 'push';
actor: { id: string; url: string };
actor: { id: string; url: string; standbyUrl?: string };
build: { id: string; number: string; status: string; url: string };
error?: { phase: 'build'; message: string; logTail: string[] };
exitCode?: number;
Expand Down Expand Up @@ -508,6 +508,14 @@ Skipping push. Use --force to override.`,

const actorUrl = `https://console.apify.com${redirectUrlPart}/actors/${build.actId}`;
const buildUrl = `${actorUrl}#/builds/${build.buildNumber}`;
// Standby actors expose an HTTP endpoint at https://<username>--<name>.apify.actor.
// Surface it in the push summary so callers don't have to guess the host or
// dig through the Console UI. Guarded on the local config flag rather than
// the platform response so it's shown consistently right after enabling
// standby via actor.json (before the platform record has been re-fetched).
const standbyUrl = actorConfig!.usesStandbyMode
? `https://${actor.username}--${actor.name}.apify.actor`
: undefined;

// Surface the tail of the build log as the failure reason. Best-effort:
// the build status already conveys the outcome if the log can't be read.
Expand All @@ -534,7 +542,7 @@ Skipping push. Use --force to override.`,
const result: PushResult = {
ok: outcome.ok,
operation: 'push',
actor: { id: build.actId, url: actorUrl },
actor: { id: build.actId, url: actorUrl, ...(standbyUrl ? { standbyUrl } : {}) },
build: { id: build.id, number: build.buildNumber, status: buildStatus, url: buildUrl },
};
if (outcome.exitCode !== undefined) {
Expand All @@ -561,6 +569,7 @@ Skipping push. Use --force to override.`,
'',
`Actor URL: ${actorUrl}`,
`Build URL: ${buildUrl}`,
...(standbyUrl ? [`Standby URL: ${standbyUrl}`] : []),
...(outcome.errorMessage && logTail.length ? ['', 'Reason:', ...logTail] : []),
];
simpleLog({ stdout: true, message: lines.join('\n') });
Expand Down
Loading