Conversation
sbiscigl
marked this pull request as ready for review
September 21, 2026 16:45
pulimsr
approved these changes
Sep 21, 2026
sbiscigl
force-pushed
the
fix-noauth
branch
from
September 22, 2026 13:27
94f4a58 to
42803aa
Compare
kai-ion
reviewed
Sep 22, 2026
| #if($operation.signerName == "Aws::Auth::SIGV4_SIGNER") | ||
| #set($signerArg = "") | ||
| #else | ||
| #set($signerArg = ", ${operation.signerName}") |
Collaborator
There was a problem hiding this comment.
is there a chance operation.signerName has a value of " "?
If so I think we can add an extra guard for empty value
Collaborator
Author
There was a problem hiding this comment.
If so I think we can add an extra guard for empty value
what do you mean extra guard? if singer is missing is in a invalid state. if signer is missing, i.e. empty value, compilation should fail, and it will because , ) is not valid code?
the same could be said about any string variable in codegen. they all could be empty, and all of them result in compilation errors before the SDK is published
sbaluja
approved these changes
Sep 22, 2026
kai-ion
approved these changes
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
(#3751), merged 2026-03-25 and shipped in 1.11.777, consolidated per-operation MakeRequest calls into a shared InvokeServiceOperation helper that hardcoded SIGV4_SIGNER, which wrongly SigV4-signed operations that must be unsigned or bearer and broke IdC browser auth. along with sso, sts, cognito-identity, cognito-idp, signin, and codecatalyst. The fix threads the model-derived signerName.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.