ci: use default branch and simplify release-plz workflow - #79
Merged
Merged
Conversation
Replace the hard-coded `master` branch check in the release-plz workflow with `github.event.repository.default_branch`. Update the workflow comments and CONTRIBUTING.md release instructions to refer to the default branch. Remove the explicit `release-pr`/`release` command choice and per-job conditionals so the workflow runs both jobs on the selected branch.
notmandatory
force-pushed
the
ci/add_release_plz_fix_3
branch
from
September 15, 2026 00:18
a910e6d to
ef5a33a
Compare
reez
reviewed
Sep 15, 2026
reez
left a comment
reez
left a comment
Contributor
There was a problem hiding this comment.
Concept ACK
2 small comments/questions
notmandatory
force-pushed
the
ci/add_release_plz_fix_3
branch
3 times, most recently
from
September 16, 2026 20:11
96ea820 to
d682236
Compare
notmandatory
force-pushed
the
ci/add_release_plz_fix_3
branch
from
September 16, 2026 20:16
d682236 to
5d36c51
Compare
reez
approved these changes
Sep 16, 2026
notmandatory
had a problem deploying
to
release
September 16, 2026 20:54 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Member
Author
|
confirmed that no release PR is created by the release-pr job if there's nothing new to release. Also that that release job tries to run but can be canceled, or if I let it run since there's not change in Cargo.toml version it won't do anything anyway (as tested manually above). https://github.com/bitcoindevkit/rust-cktap/actions/runs/35149348286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the hard-coded
masterbranch check in the release-plz workflow withgithub.event.repository.default_branch. Update the workflow comments and CONTRIBUTING.md release instructions to refer to the default branch. Remove the explicitrelease-pr/releasecommand choice and per-job conditionals so the workflow runs both jobs on the selected branch.Notes to the reviewers
This should be the last change to the release workflow. I didn't want to make it completely automated since that would prevent us from starting the release workflow on different branches. Only one release can be active at one time per the release-plz tool.
I also fixed #78
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing