Repository navigation
Run tests on PHP 8.5 and update test environment - #47
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility guards are complete and the dependency and CI updates align with PHP 8.5 support.
0 open findings
What changed in this PR
Updates the test environment for PHP 8.5 while preserving compatibility with PHP 5.3.
Changes:
- Adds PHP 8.5 to CI.
- Avoids deprecated
ReflectionProperty::setAccessible()calls on PHP 8.1+. - Raises ReactPHP dependency minimums to compatible releases.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Tests against PHP 8.5. |
composer.json |
Updates ReactPHP dependency constraints. |
tests/IntegrationSshProcessConnectorTest.php |
Guards reflection accessibility calls. |
tests/SshProcessConnectorTest.php |
Guards reflection accessibility calls. |
tests/SshSocksConnectorTest.php |
Guards reflection accessibility calls. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to run the test suite on PHP 8.5, which deprecates the
setAccessible()calls used in our tests.Builds on top of #46, clue/reactphp-socks#124, reactphp/socket#325, reactphp/promise#264, reactphp/event-loop#282, reactphp/child-process#119, and clue/framework-x#297