Skip to content

Handle symlinks from breaking the tool - #37

Open
DMarinhoCodacy wants to merge 1 commit into
mainfrom
handling-symlinks
Open

DMarinhoCodacy wants to merge 1 commit into
mainfrom
handling-symlinks

Conversation

@DMarinhoCodacy

Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The new filtering may silently discard all pathless Semgrep errors, including unrelated configuration, invocation, or runtime failures—not just symlink-related errors. This should be restricted to the known symlink condition or otherwise preserve project-level failures before merging.

Both required behaviors lack automated tests: skipping empty-path errors and retaining valid-path errors.

About this PR

  • Add automated tests covering both the empty-path filtering behavior and preservation of valid-path errors.

Test suggestions

  • appendErrorToResult skips an error whose location path is empty.
  • appendErrorToResult preserves a valid-path error in the result.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. appendErrorToResult skips an error whose location path is empty.
2. appendErrorToResult preserves a valid-path error in the result.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant