Handle symlinks from breaking the tool - #37
Open
DMarinhoCodacy wants to merge 1 commit into
Open
DMarinhoCodacy wants to merge 1 commit into
DMarinhoCodacy wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The new filtering may silently discard all pathless Semgrep errors, including unrelated configuration, invocation, or runtime failures—not just symlink-related errors. This should be restricted to the known symlink condition or otherwise preserve project-level failures before merging.
Both required behaviors lack automated tests: skipping empty-path errors and retaining valid-path errors.
About this PR
- Add automated tests covering both the empty-path filtering behavior and preservation of valid-path errors.
Test suggestions
- appendErrorToResult skips an error whose location path is empty.
- appendErrorToResult preserves a valid-path error in the result.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. appendErrorToResult skips an error whose location path is empty.
2. appendErrorToResult preserves a valid-path error in the result.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.