Skip to content

refactor: make BaseService and BaseCollector abstract - #10531

Open
samsonasik wants to merge 1 commit into
codeigniter4:4.8from
samsonasik:refactor-base-abstract
Open

refactor: make BaseService and BaseCollector abstract#10531
samsonasik wants to merge 1 commit into
codeigniter4:4.8from
samsonasik:refactor-base-abstract

Conversation

@samsonasik

@samsonasik samsonasik commented Sep 7, 2026

Copy link
Copy Markdown
Member

Description

This PR target to 4.8, change 2 files:

  • system/Config/BaseService.php
  • system/Debug/Toolbar/Collectors/BaseCollector.php

in the system or tests, they never instantiated, only extended, verified with structarmed ExtendedClassMustBeAbstractOrInstantiatedRule for future new Base+ prefix classes to be abstract.

->layerPattern('BaseClasses', '/^CodeIgniter\\\\.*Base.*$/')
->rule('base_classes.must_be_abstract', new ExtendedClassMustBeAbstractOrInstantiatedRule('BaseClasses'))

If you want to only apply the changes class change only to easier for back and forth develop and 4.8 branch, just let me know ;)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.8 PRs that target the `4.8` branch. labels Sep 7, 2026
@samsonasik

Copy link
Copy Markdown
Member Author

Ready for review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant