Conversation
…essages getErrorMessage() resolved a rule parameter as a key into the field rules to substitute the referenced field's label. A parameter that was not a field reference (e.g. min_length[secret]) could coincidentally match a defined field name and leak its label into the error message. Label substitution now only applies to field-referencing rules (matches, differs, required_with, required_without).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validation::getErrorMessage()used the rule parameter as a key into thedefined field rules to substitute the referenced field's label in the error
message. When a parameter that was not a field reference (e.g. a numeric
limit like
min_length[secret]) coincidentally matched a defined fieldname, that field's label leaked into the error message (information
disclosure of internal field labels plus a wrong message).
Label substitution now only applies to rules whose parameter is a field
reference:
matches,differs,required_with,required_without. Otherrules render the parameter verbatim.
Checklist: