Repository navigation
Conversation
The coverage filter still matched the former module path, leaving test\nhelpers in the report. Match the current module path and name the\nbenchmark for the library it measures.
mafredri
marked this pull request as ready for review
October 23, 2026 14:20
mafredri
enabled auto-merge (squash)
October 23, 2026 14:26
mafredri
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the six remaining issue and pull-request links from
github.com/nhooyr/websockettogithub.com/coder/websocket, and renames the masking benchmark fromnhooyr-gotocoder-go.Fixes the coverage filter, which still matched
nhooyr.io/websocket/internal/testand therefore left test helpers in coverage reports. It now matchesgithub.com/coder/websocket/internal/test/.The README acknowledgement and the
@nhooyrcomment remain unchanged, as do thenhooyr.ioURLs used to test dial errors.Follows #567.
Verification
make fmt lint test bench, native and WASM builds, and ARM64 masking checks passed. Lint and tests were also rerun with Go 1.26.10.coder/coderat63f3bde725. All 310 tested packages passed across the full-suite run and a CLI rerun; the CLI initially failed because the workspace Git wrapper could not run with an empty environment. A process-localPATHchange selected system Git for the rerun.The installed pre-commit hook requires
shfmtformatting for the modified test script.