Adding CEL based principal extractor for custom environments. - #133
Open
dawid-nowak wants to merge 6 commits into
Open
Adding CEL based principal extractor for custom environments.#133dawid-nowak wants to merge 6 commits into
dawid-nowak wants to merge 6 commits into
Conversation
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
lucarlig
requested changes
Sep 7, 2026
lucarlig
left a comment
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
2 issues @dawid-nowak :
using "sub":"<existing-user>", "tenant_id":" " (Blank tenant). i get 404 does it mean authentication passed? Would expect 401.
"sub":"<existing-user>", "tenantId":null, "tenant_id":"acme" finds tenantId null and gives 401, before we had fallback to check whole fields including tenant_id that in this case would come after is this intended?
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.