Repository navigation
fix(Tooltip, Popover): cancel the show timer and drop aria-describedby on hide, empty content and destroy - #313
Merged
Conversation
…y on hide, empty content and destroy Hide or empty content within 150 ms of show let the timer set aria-describedby to a detached tooltip; empty content after show kept the old id; destroy ran the timer on a dead view.
xidedix
force-pushed
the
fix/tooltip-popover-quick-hide
branch
from
October 19, 2026 22:33
b7e22a5 to
6326372
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltip and Popover left the host with
aria-describedbypointing at a tooltip that no longer exists.tooltipIdand droppedd-none, then the hide timer detached the view.destroyTooltipElement()now cancels both timers and clearstooltipId,removeTooltipElement()cancels the show timer, and the empty-content branch marks the host for check so the binding drops the id.Verified: lint, full suite, lib build; on the docs tooltip page five quick hover/leave runs leave a dangling id on 5.7.37 and none with this change; other tooltip, popover, dropdown, widgets and sidebar checks unchanged.