Allow linking on sub-paths to cs3d without changing cs3d generated code - #5
Open
wayfarer3130 wants to merge 1 commit into
Open
Allow linking on sub-paths to cs3d without changing cs3d generated code#5wayfarer3130 wants to merge 1 commit into
wayfarer3130 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change switches Cornerstone packages to local monorepo paths, updates worker bundling and browser stubs, adds codec asset configuration, and supports fallback lookup across repository and sibling monorepo dependencies. ChangesCornerstone local integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant setup()
participant csRenderInit
participant DICOM image loader
setup()->>csRenderInit: provide peerImport codec URL resolver
setup()->>DICOM image loader: provide codec import paths and base path
csRenderInit->>DICOM image loader: use configured codec assets
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the old modify paths directly in generated code, and links to CS3D 5.x branches
Summary by CodeRabbit
Bug Fixes
Refactor