Skip to content

fix: typo in lottie animation - #90

Merged
jbw976 merged 1 commit into
crossplane:mainfrom
Remsboys:fix/lottie
Aug 26, 2026
Merged

fix: typo in lottie animation#90
jbw976 merged 1 commit into
crossplane:mainfrom
Remsboys:fix/lottie

Conversation

@Remsboys

Copy link
Copy Markdown
Contributor

Fix the typo in the parameter "jsonpath" on the front-page Lottie animation.
With the change the double quotes are also replaced with single quotes. This adheres to the best practices in the Kubernetes community (https://kubernetes.io/docs/reference/kubectl/jsonpath/).

The original Lottie has been created with Adobe After Effects, exported with the Bodymovin plugin. Unfortunately the source file hasn't been committed.
With the help of Claude Opus 5, the typos have been fixed by rearranging existing layers.

Fixes #45

Signed-off-by: Remsboys <71826922+Remsboys@users.noreply.github.com>
@netlify

netlify Bot commented Aug 16, 2026

Copy link
Copy Markdown

Deploy Preview for crossplane-site ready!

Name Link
🔨 Latest commit 65645d4
🔍 Latest deploy log https://app.netlify.com/projects/crossplane-site/deploys/6a822b2f58fa1800089306e7
😎 Deploy Preview https://deploy-preview-90--crossplane-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jbw976 jbw976 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking the initiative to fix this issue!

the change is a bit hard to review (no fault of yours) because it's a 2KB single line of minified json that is being edited and it also has some encoded data in it, so I'm pretty cautious here of accepting this change (that's exactly how malicious hacks get introduced to projects).

I've taken some extra precautions using some tools to verify this change further, and the findings indicate this is safe:

  • Only 5 of the file's 164 layers differ: two quote-stroke layers removed, one j glyph added, two repositioned. Every other layer is byte-identical.
  • There are no Lottie expressions anywhere in the file, which as far as I know is the only thing in a Lottie that lottie-web will evaluate. No URLs, no script, no eval either.
  • The one embedded base64 asset (the background PNG) is byte-identical before and after, same SHA-256.
  • Both versions were rendered frame by frame, and it looks like the only pixels that change are on the one text line being fixed, between frames 73 and 239.

My human eyes on the preview site https://deploy-preview-90--crossplane-site.netlify.app/ show that this change appears to work OK and fix the issue as well. This should be OK to merge ✅

@jbw976
jbw976 merged commit bbc13e6 into crossplane:main Aug 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in public/animations/coding.json

2 participants