Reject invalid dashboard parent_path in test server#5995
Draft
radakam wants to merge 2 commits into
Draft
Conversation
The fake DashboardCreate stored any parent_path verbatim unless it began with /Workspace/, so a value that isn't a real workspace folder (e.g. a path-traversal string like /etc/passwd) round-tripped through GET and surfaced as spurious drift under the direct engine. Validate parent_path the way cloud does: require an absolute, canonical path free of control characters and rooted under a real workspace directory (/Users, /Repos, /Shared), returning 400 otherwise. Existence alone is not sufficient, since such a directory may have been created earlier.
Collaborator
Integration test reportCommit: c98199f
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 2 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.