feat: add HPA controller for workload deployments - #203
Merged
Conversation
scotwells
previously approved these changes
Aug 3, 2026
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
@savme can we add a chainsaw end to end test to validate this behavior? I think for this we can just validate that the HPA is lifecycle correctly based on auto-scale settings.
Longer-term we need to think about how we can validate auto-scaling behavior in CI so we can confirm that custom metrics we export for instances can trigger auto-scaling.
savme
force-pushed
the
feat/workloaddeployment-hpa-controller
branch
from
August 4, 2026 13:56
4517f0d to
77e6dca
Compare
scotwells
previously approved these changes
Aug 5, 2026
stack merge was automatically disabled
August 11, 2026 10:22
Pull Request is not mergeable
stack merge was automatically disabled
August 11, 2026 10:22
Pull Request is not mergeable
savme
force-pushed
the
feat/workloaddeployment-hpa-controller
branch
from
August 11, 2026 10:23
77e6dca to
dd973b7
Compare
Base automatically changed from
feat/workloaddeployment-scale-subresource
to
main
August 11, 2026 10:25
savme
force-pushed
the
feat/workloaddeployment-hpa-controller
branch
from
August 11, 2026 10:26
dd973b7 to
6371c6d
Compare
Contributor
Author
|
No changes since the last review. Just github stacked PRs being a bit awkward to use 😒 |
scotwells
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the cell-local autoscaling controller for
WorkloadDeployment.When a
WorkloadDeploymenthas autoscaling enabled, the controller creates and keeps a matching HPA up to date. The HPA stays local to the cell and is not propagated through karmada. This uses the existing CPU and memory metric settings for configuration.Note that
Resourcemetrics still need to be served for pods created by kraftlet. This will be added in a follow-up.Related to datum-cloud/enhancements#799