Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Clarify that direct construction makes the consuming class harder to unit test.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the dependency injection overview with clearer guidance on direct dependencies and unit testing.
Changes:
- Clarifies implementation replacement costs.
- Expands the unit-testing rationale.
- Updates document metadata.
File summaries
| File | Summary |
|---|---|
aspnetcore/fundamentals/dependency-injection.md |
Updates DI guidance and metadata; clarifies the affected class in the testing explanation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Clarified the unit testing challenges related to direct dependencies in dependency injection. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28220
Thanks @m-brooks! 🚀
... and sorry for the delay in us reaching your issue. We've been very busy around here ..... for years! ⛏️😅😆
Tom ... Found this DI issue while surveying issues for the Blazor work. See if fleshing out these remarks looks good.
Internal previews
Build report