Fix line number reference for _headersToExclude - #37683
Merged
Merged
Conversation
Updated the line number in RequestUtilities.cs from 71 (which is currently in the body of `ShouldSkipResponseHeader`) to 75 (which is currently where `_headersToExclude` is defined). Line 71 pointed to `_headersToExclude` prior to commit 6a06dfd (see dotnet/yarp@6a06dfd#diff-6125b9d8845ce5294ef3c04927a2ee6417b54d48e5ddf62c4e4d1035ec2f408c )
wadepickett
reviewed
Sep 18, 2026
wadepickett
approved these changes
Sep 18, 2026
wadepickett
left a comment
wadepickett
left a comment
Contributor
There was a problem hiding this comment.
@CalebBellWebCE, thanks very much for this update! Approved. Merging..
Contributor
|
@tdykstra, @meaghanlewis, or @guardrex, I need a re-approval for this one since I made a small change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the line number in RequestUtilities.cs from 71 (which is currently in the body of
ShouldSkipResponseHeader) to 75 (which is currently where_headersToExcludeis defined). Line 71 pointed to_headersToExcludeprior to commit 6a06dfd (see dotnet/yarp@6a06dfd#diff-6125b9d8845ce5294ef3c04927a2ee6417b54d48e5ddf62c4e4d1035ec2f408c )Internal previews
Build report