Skip to content

[docs] Improve XML docs for CIVector, SCNText, UIDeviceOrientationExtensions, UISearchBar, and NSAttributedString - #26327

Merged
rolfbjarne merged 8 commits into
mainfrom
dev/rolf/xmldocs-037-batch
Jul 28, 2026
Merged

[docs] Improve XML docs for CIVector, SCNText, UIDeviceOrientationExtensions, UISearchBar, and NSAttributedString#26327
rolfbjarne merged 8 commits into
mainfrom
dev/rolf/xmldocs-037-batch

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Improve XML documentation for the following types:

  • CIVector — Fix tag ordering, remove empty returns element, improve constructor summaries
  • SCNText — Fix tag ordering, improve Create method summaries
  • UIDeviceOrientationExtensions — Fix tag ordering and indentation
  • UISearchBar — Fix tag ordering and indentation for scope bar methods
  • NSAttributedString (macOS) — Fix tag ordering, improve GetAppKitAttributes summaries

Changes include:

  • Reorder XML doc tags (summary before param)
  • Normalize indentation (single space after ///)
  • Remove empty <returns> and <value> elements
  • Improve placeholder summaries that just repeated the method name

🤖 Pull request created by Copilot

rolfbjarne and others added 6 commits July 28, 2026 14:25
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tch 037

Fix param-before-summary ordering in CIVector, SCNText, UISearchBar,
UIDeviceOrientationExtensions, UIInterfaceOrientationExtensions, and
NSAttributedString. Fix extra whitespace indentation. Remove empty
returns/value elements. Improve placeholder summaries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Copilot AI review requested due to automatic review settings July 28, 2026 12:33
@rolfbjarne
rolfbjarne requested a review from dalexsoto as a code owner July 28, 2026 12:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates XML documentation across several Apple-platform binding types to improve generated API docs quality by normalizing tag ordering/indentation and replacing placeholder text with meaningful summaries.

Changes:

  • Reordered XML doc tags (placing <summary> before <param>), normalized indentation, and removed empty <returns>/<value> elements.
  • Improved summaries for selected APIs (notably CIVector constructors, SCNText.Create, and macOS NSAttributedString.GetAppKitAttributes).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/UIKit/UISearchBar.cs Refines XML docs for scope bar appearance helpers (but introduces two summary mismatches that should be corrected).
src/UIKit/UIEnumsExtensions.cs Cleans up XML docs/tag ordering for orientation extension methods (type summary should say “enum/enumeration”, not “class”).
src/SceneKit/Constructors.cs Replaces placeholder docs for SCNText.Create overloads with descriptive summaries/params.
src/Foundation/NSAttributedString.mac.cs Improves summaries/params for GetAppKitAttributes overloads on macOS.
src/CoreImage/CIVector.cs Improves constructor/method docs and removes empty <returns>/<remarks> blocks.
Comments suppressed due to low confidence (1)

src/UIKit/UISearchBar.cs:56

  • This method returns TextAttributes, but the summary says it gets a "background image". This looks like a copy/paste mistake; update the summary to match the method name/return type (scope bar button title text attributes).
			/// <summary>Gets the background image for the scope bar button for the specified state.</summary>
			/// <param name="state">The state.</param>
			public TextAttributes GetScopeBarButtonTitleTextAttributes (UIControlState state)

Comment thread src/UIKit/UISearchBar.cs Outdated
Comment thread src/UIKit/UIEnumsExtensions.cs Outdated
@vs-mobiletools-engineering-service2

This comment has been minimized.

- Fix UISearchBar: summaries now say 'text attributes' not 'title'
- Fix UIDeviceOrientationExtensions: say 'enumeration' not 'class'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne added the ready-to-review This PR is ready to review/merge. label Jul 28, 2026
@rolfbjarne
rolfbjarne enabled auto-merge (squash) July 28, 2026 14:32
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 175c1b8276716b2b7a0fb84e0e2cfb7d871ddede [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #175c1b8] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 203 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 175c1b8276716b2b7a0fb84e0e2cfb7d871ddede [PR build]

@rolfbjarne
rolfbjarne merged commit 1568a7c into main Jul 28, 2026
56 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/xmldocs-037-batch branch July 28, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot ready-to-review This PR is ready to review/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants