Update winget install instructions in windows-requirements.md - #131462
Conversation
- Install Visual Studio using the repo's `.vsconfig` instead of a hand-written workload list. The previous `--add NativeDesktop --add ManagedDesktop --includeRecommended` set omitted `VC.Tools.ARM64` and `VC.CLI.Support`, which are required to target Arm64 and to build the tests respectively. - Use the current VS package id (`Microsoft.VisualStudio.Community`, VS 2026); `Microsoft.VisualStudio.2022.Community` pins the old release. - Bump Python from 3.11 to 3.14. - Add a note for Arm64 machines: the VS winget manifest only publishes an x64 bootstrapper (which installs native Arm64 VS under emulation), while all the other packages listed have native Arm64 installers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9209dcba-f5be-4955-ae92-648a55b502eb
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Updates the Windows developer setup documentation to refresh the winget-based installation instructions, especially around Visual Studio installation, to better align with the repo’s .vsconfig.
Changes:
- Update
wingetPython install fromPython.Python.3.11toPython.Python.3.14. - Update Visual Studio
wingetinstall command to useMicrosoft.VisualStudio.Communityand pass the repo’s.vsconfig. - Add a short explanatory note about using
.vsconfigand Arm64wingetbehavior for Visual Studio.
Use $PWD\.vsconfig instead of a <path-to-runtime-repo> placeholder, and note that the command is meant to be run from the root of the clone. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9209dcba-f5be-4955-ae92-648a55b502eb
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/workflow/requirements/windows-requirements.md:97
- The
--configpath in the Visual Studio--overridestring isn’t quoted. If the runtime repo path contains spaces, the VS bootstrapper may split the path into multiple args and fail to find.vsconfig. Quote the expanded path within the override value.
winget install -e --id Microsoft.VisualStudio.Community --override "--passive --wait --config $PWD\.vsconfig"
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9209dcba-f5be-4955-ae92-648a55b502eb
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/workflow/requirements/windows-requirements.md:97
- The
--config $PWD\.vsconfigargument is unquoted inside the--overridestring, which will break if the repo path contains spaces (the VS bootstrapper will see a split argument). Also, using$PWD\.vsconfigimplicitly assumes the command is run from the repo root (and that.vsconfigis already available), which isn’t stated here.
Consider using an explicit <path-to-runtime-repo>\.vsconfig placeholder and quoting the path within the override string (PowerShell needs doubled quotes inside a double-quoted argument).
winget install -e --id Microsoft.VisualStudio.Community --override "--passive --wait --config $PWD\.vsconfig"
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
docs/workflow/requirements/windows-requirements.md:97
- The Visual Studio
--configpath is not quoted. If the repo path contains spaces (common on Windows), the installer will treat it as multiple arguments and the command can fail. Quote the config path inside the--overridestring.
winget install -e --id Microsoft.VisualStudio.Community --override "--passive --wait --config $PWD\.vsconfig"
docs/workflow/requirements/windows-requirements.md:101
- The PR description says an Arm64 note was added (including the
-a x64workaround ifwingetrefuses to fall back), but the updatedwingetsection in this file doesn't include it. Either add the note here or adjust the PR description to match.
The last command installs the components listed in the repo's [`.vsconfig`](https://github.com/dotnet/runtime/blob/main/.vsconfig), so run it from the root of your clone.
|
PTAL @jkoritzinsky |
Small refresh of the
wingetsection indocs/workflow/requirements/windows-requirements.md.Tested on a real clean win-arm64 machine.