[ci-scan-feedback] Route platform-specific crypto-config failures to loop-in - #131469
Open
kotlarmilos with Copilot wants to merge 2 commits into
Open
[ci-scan-feedback] Route platform-specific crypto-config failures to loop-in#131469kotlarmilos with Copilot wants to merge 2 commits into
kotlarmilos with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Route platform-specific crypto-config failures to loop-in
[ci-scan-feedback] Route platform-specific crypto-config failures to loop-in
Jul 28, 2026
kotlarmilos
marked this pull request as ready for review
July 28, 2026 14:40
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
bartonjs
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ci-failure-fixagentic workflow lacked a gate forSystem.Security.Cryptography.*tests that fail only under a specific distro crypto configuration, causing speculative confident/help PRs that guess a distro-specific expectation (the #130594 failure mode). This drove the 30-day fixer rejection rate to 40%.Changes
.github/workflows/ci-failure-fix.md(Step 5.2) — Added a Platform crypto-config caution after the "Already-rooted test-assembly caution" paragraph. When aSystem.Security.Cryptography.*test fails only on a specific distro/OS crypto configuration (AzureLinux/mariner,linux_musl, FIPS, OpenSSL-provider variant) and the candidate change would hard-code a platform-specific crypto expectation (key-size floor, algorithm availability, cipher enable/disable, or a per-distro test-expectation change), the fixer must route to Branch COMMENT (loop-in) — or Branch HELP only with the platform crypto config named as the explicit open question — and never open a confident (Branch FIX) PR for this shape.Notes
ci-failure-fix.lock.yml({{#runtime-import}}), so no lock-file regeneration is required and no product code, tests, or build config are affected.AiaCompletionHasLimitsKBE ([ci-scan] Test failure: System.Security.Cryptography.X509Certificates.Tests.RevocationTests.AiaTests.AiaCompletionHasLimits #130947), handing distro-config decisions to the security area owners.