Follow the analysis options of the frontend plugins - #1144
Merged
Conversation
The root analysis_options.yaml mirrors flutter/packages, which is only the right baseline for ports of flutter/packages plugins. Give the ports of third-party plugins their own analysis_options.yaml replicating the one the frontend plugin ships: * flutter_inappwebview: package:flutter_lints, plus the error suppressions the frontend plugin declares. * sqflite: package:flutter_lints, plus its strict language modes and rules. * keyboard_detection: package:flutter_lints. * flutter_webrtc, flutter_tts: package:lints/recommended, plus their rules, error severities and strict language modes. firebase_core keeps using the root options because flutterfire's options include a repository-local all_lint_rules.yaml that cannot be referenced from here, and flutter_app_badger keeps using them because its frontend plugin has no analysis options at all.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97ba19d424
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xiaowei-guan
approved these changes
Sep 7, 2026
lints 5.0.0 and flutter_lints 5.0.0 require Dart 3.5, but flutter_tts and keyboard_detection allow Dart 3.1 and flutter_webrtc allows Dart 3.3, so `pub get` failed for anyone developing on the minimum supported SDK. Use the 4.0.0 line, which requires Dart 3.1, the way battery_plus and wakelock_plus already pin theirs to their own SDK ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root analysis_options.yaml mirrors flutter/packages, which is only the right baseline for ports of flutter/packages plugins. Give the ports of third-party plugins their own analysis_options.yaml replicating the one the frontend plugin ships:
firebase_core keeps using the root options because flutterfire's options include a repository-local all_lint_rules.yaml that cannot be referenced from here, and flutter_app_badger keeps using them because its frontend plugin has no analysis options at all.