Skip to content

perf(crashpad): Send event updates over IPC#1841

Open
jpnurmi wants to merge 7 commits into
masterfrom
jpnurmi/feat/crashpad-ipz
Open

perf(crashpad): Send event updates over IPC#1841
jpnurmi wants to merge 7 commits into
masterfrom
jpnurmi/feat/crashpad-ipz

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Pass crash event, breadcrumbs, and external crash report updates to the Crashpad client and let it decide between IPC (Windows) or direct file writes (Unix).

According to local benchmarks with Windows Defender exclusions, it shaves off ~50% on Windows:

Before

tests/benchmark.py::test_benchmark_scope[crashpad-set_tag] PASSED
Min 1.177ms, Max 1.177ms, Mean 1.177ms, Median 1.177ms

After

tests/benchmark.py::test_benchmark_scope[crashpad-set_tag] PASSED
Min 0.570ms, Max 0.570ms, Mean 0.570ms, Median 0.570ms

For users with Windows Defender enabled, occasional scan delays are avoided in the client process, and savings therefore can be significantly more.

Depends on:

@jpnurmi jpnurmi changed the title feat: Send crashpad event updates over IPC WIP: perf(crashpad): Send event updates over IPC Jul 6, 2026
Comment thread src/backends/sentry_backend_crashpad.cpp Outdated
Comment thread src/backends/sentry_backend_crashpad.cpp Outdated
Comment thread src/backends/sentry_backend_crashpad.cpp Outdated
Comment thread src/backends/sentry_backend_crashpad.cpp
@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crashpad-ipz branch from 6887029 to ed18914 Compare July 6, 2026 14:22
Comment thread src/backends/sentry_backend_crashpad.cpp
Comment thread src/backends/sentry_backend_crashpad.cpp
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.69565% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.74%. Comparing base (b742b8d) to head (b02b89a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   75.76%   75.74%   -0.03%     
==========================================
  Files          92       92              
  Lines       21989    22023      +34     
  Branches     3918     3924       +6     
==========================================
+ Hits        16661    16681      +20     
- Misses       4447     4457      +10     
- Partials      881      885       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jpnurmi and others added 2 commits July 24, 2026 12:30
Send serialized crash event and external crash report data to the Crashpad
handler for file writes. Keep the existing file-write fallback for payloads
that cannot be sent through the handler IPC.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crashpad-ipz branch from fe406f1 to ea01e18 Compare July 24, 2026 10:31

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ea01e18. Configure here.

Comment thread src/backends/sentry_backend_crashpad.cpp Outdated
Comment thread src/backends/sentry_backend_crashpad.cpp
Comment thread src/backends/sentry_backend_crashpad.cpp
@jpnurmi jpnurmi changed the title WIP: perf(crashpad): Send event updates over IPC perf(crashpad): Send event updates over IPC Jul 24, 2026
@jpnurmi
jpnurmi requested a review from mujacica July 24, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants