Skip to content

ref(pyramid): Drop send_default_pii support - #7693

Merged
pabloDeputter merged 3 commits into
major/3.0from
pablo/pyramid-drop-pii
Sep 24, 2026
Merged

pabloDeputter merged 3 commits into
major/3.0from
pablo/pyramid-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

Issues

Resolves #7606

@pabloDeputter
pabloDeputter changed the base branch from master to major/3.0 September 24, 2026 09:09
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 63242 passed | ❌ 1 failed | ⏭️ 2883 skipped | Total: 66126 | Pass Rate: 95.64% | Execution Time: 176m 52s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -67867
Passed Tests 📉 -63597
Failed Tests 📉 -1
Skipped Tests 📉 -4269

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140428024332288

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140428024332288

✅ Patch coverage is 100.00%. Project has 2078 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (43b3bcd) to head (dd9bfe6).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.10%    -0.12%
==========================================
  Files          194       178       -16
  Lines        25997     20988     -5009
  Branches      9662      7572     -2090
==========================================
+ Hits         23454     18910     -4544
- Misses        2543      2078      -465
- Partials      1451      1197      -254

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 24, 2026 14:16
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 24, 2026 14:16
@pabloDeputter
pabloDeputter merged commit 41bc733 into major/3.0 Sep 24, 2026
145 of 147 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/pyramid-drop-pii branch September 24, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove send_default_pii from pyramid

2 participants