fix: fall back when get_check_runs lacks Checks API access#2623
Open
advancedresearcharray wants to merge 1 commit into
Open
fix: fall back when get_check_runs lacks Checks API access#2623advancedresearcharray wants to merge 1 commit into
advancedresearcharray wants to merge 1 commit into
Conversation
advancedresearcharray
force-pushed
the
fix/get-check-runs-fallback-2381
branch
from
1d662b4 to
7330c03
Compare
Hosted MCP tokens often lack checks:read even when other PR read methods succeed. Retry via workflow runs and commit statuses on 403, and return clearer permission guidance when all sources are denied. Closes github#2381
advancedresearcharray
force-pushed
the
fix/get-check-runs-fallback-2381
branch
from
7330c03 to
49c3197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_readget_check_runswhen the Checks API returns 403sourcefield indicating which API supplied the dataWhy
Fixes #2381. Hosted MCP tokens often lack
checks:readeven though other PR read methods work and the equivalent REST call succeeds with the caller's PAT. This makesget_check_runsunusable in that environment.What changed
pkg/github/check_runs.goMinimalCheckRunsourcetoMinimalCheckRunsResult(checks_api,workflow_runs,commit_statuses)Test plan
go test -run Test_GetPullRequestCheckRuns ./pkg/github/...go test -run Test_convertWorkflowRun ./pkg/github/...go test -run Test_convertCommitStatus ./pkg/github/...go test ./pkg/github/...(no regressions)