Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The compatibility warning conflates the CLI and IDE version tracks.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates Antigravity integration compatibility, execution flags, safety controls, documentation, and tests.
Changes:
- Adds model, JSON output, extra-argument ordering, and opt-in permission bypass.
- Delegates skill post-processing to
SkillsIntegration. - Updates catalog metadata, documentation, and test coverage.
File summaries
| File | Description |
|---|---|
src/specify_cli/integrations/agy/__init__.py |
Updates execution and setup behavior. |
tests/integrations/test_integration_agy.py |
Expands regression coverage. |
integrations/catalog.json |
Adds CLI metadata. |
docs/reference/integrations.md |
Documents layout and permission configuration. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mnriem
added
the
triage-nice-to-have
mnriem
added
author-awaiting
mnriem
requested changes
Sep 18, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve conflicts
Support --model, --output-format json, and opt-in permissions bypass. Position options before prompt and inherit hook normalization from base. Add CLI catalog tags and comprehensive integration tests.
stn1slv
force-pushed
the
fix/agy-cli-compatibility
branch
from
September 18, 2026 13:36
226465b to
1ac22ec
Compare
Clarify CLI and IDE version tracks per review feedback on PR github#4612. Harden workspace path resolution and assert manifest hash tracking. Isolate environment state and verify exact argument ordering.
Contributor
Author
|
Rebased on main and resolved conflicts. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
This pull request updates the Antigravity (
agy) integration to support modern Antigravity CLI features and align with Spec Kit conventions:--model <model>and--output-format jsoninAgyIntegration.build_exec_args().SPECKIT_INTEGRATION_AGY_EXTRA_ARGS) before the positional--print <prompt>argument pair.--dangerously-skip-permissions, disabled by default and controllable viaSPECKIT_AGY_ALLOW_ALL_TOOLS=1orSPECKIT_INTEGRATION_AGY_ALLOW_ALL_TOOLS=1. Empty or blank strings in the specific override fall through cleanly to the generic variable.SkillsIntegrationfor hook command normalization and post-processing, removing duplicate regex code and redundant file rewrite loops.v1.0.0or newer instead ofv1.20.5.integrations/catalog.jsonwith theclitag and clarifies CLI and IDE support in the description.tests/integrations/test_integration_agy.pyto 58 tests covering all argument configurations, precedence rules, and test environment isolation.Why
--modeland JSON output mode, butbuild_exec_args()previously dropped both parameters.--print <prompt>ensures reliable argument parsing.1.20.5does not correspond to Antigravity CLI versions, causing confusion during project initialization.clitag, preventing Antigravity from appearing in CLI integration listings.Testing
uv run specify --helpuv sync && uv run pytestAdditional test details:
uv run pytest tests/integrations/test_integration_agy.py -v: 58/58 passed.uv run pytest tests/integrations/test_integration_catalog.py tests/contract/test_catalog_schema.py: 179/179 passed.uv run pytest tests/test_agent_config_consistency.py: 28/28 passed.uv run ruff checkanduv run ruff format --check: clean.AI Disclosure
Investigated compatibility and CLI flag behavior, implemented argument handling and test cases, and ran multi-model reviews using Google Antigravity pair programming under human supervision.