[Crane: crane-migration-python-to-go-full-apm-cli-rewrite]#117
Draft
github-actions[bot] wants to merge 2 commits into
Draft
[Crane: crane-migration-python-to-go-full-apm-cli-rewrite]#117github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…79: fix cache subcommand --help routing; add --force/--yes flags and output parity
Changes:
- cmd/apm/cmd_cache.go: fix runCache to route subcommand --help to the
subcommand handler instead of intercepting all --help flags at the
top level (cache clean --help and cache prune --help now show their
own usage, not the top-level cache menu)
- cmd/apm/cmd_cache.go: add -f/--force and -y/--yes flags to cache clean
help text; align output messages to Python ('Cleaning cache...' +
'Cache cleaned.' instead of 'Cache cleared: <dir>')
- cmd/apm/parity_harness_test.go: add 3 new parity contract tests
(GoCacheCleanHelp, GoCachePruneHelp, GoCacheCleanOutputMessages)
Score: 1.0 (858/858 parity, 903 Go tests, 247 Python tests, all 13 gates pass)
Run: https://github.com/githubnext/apm/actions/runs/27236411257
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
Migration Benchmark Results
Migration CLI BenchmarkIncludes fixture-backed commands that must read, write, execute, or fail against real project state. The installed-project fixture contains apm.yml, apm.lock.yaml, apm_modules packages, local .apm primitives, target directories, deployed prompt files, and sample source files. Max allowed Go/Python median ratio:
Workloads
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[bot] This PR is maintained by Crane. Each accepted iteration adds a commit to this branch.
Migration: Python 3.10+ (CPython, Click, Rich) -> Go (native binary)
Strategy: greenfield
Migration Issue: #78
State File:
crane-migration-python-to-go-full-apm-cli-rewrite.mdIteration 79 -- Stale-Completion Reset + Cache Parity Fix
Status: Accepted -- Completion Candidate (fresh stale-completion reset after PR #115 merged)
Changes in this iteration:
cmd/apm/cmd_cache.go: fixrunCacheto route subcommand--helpto the correct handler instead of intercepting all--helpflags at the top level; add-f/--forceand-y/--yesflags tocache cleanhelp text; align output messages ([*] Cleaning cache...+[+] Cache cleaned.) to match Pythoncmd/apm/parity_harness_test.go: add 3 new parity contract tests (GoCacheCleanHelp, GoCachePruneHelp, GoCacheCleanOutputMessages)All 13 deletion-grade gates: python_reference_required, surface_parity, help_parity, functional_contracts, state_diff_contracts, python_behavior_contracts, golden_fixture_corpus, all_go_golden_tests, no_python_runtime_dependency, known_exceptions=0, go_tests, python_tests, benchmarks.