fix(ui): restore log search option selection highlight#3005
Open
sjuxax wants to merge 3 commits into
Open
Conversation
Option rows used theme.text(focused, false), which only dimmed non-focused lines and never applied selection_bg. TextInputComponent::enabled also stopped updating textarea styles after the tui-textarea migration, so the cursor stayed visible when navigating checkboxes. Use theme.text(true, selected) for option focus, refresh textarea style/cursor on enabled(), and keep jump-to-SHA field focused (invalid SHA still uses block danger styling).
Satisfies clippy::missing_const_for_fn under nursery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3004 .
Option rows used theme.text(focused, false), which only dimmed non-focused lines and never applied selection_bg.
Use theme.text(true, selected) for option focus, refresh textarea style/cursor on enabled(), and keep jump-to-SHA field focused (invalid SHA still uses block danger styling).
This code was written by Grok 4.5.
Followed the checklist:
make checkwithout errors