Sync a few templates with upstream Godot - #2039
Merged
Merged
Conversation
Ivorforce
requested changes
Aug 4, 2026
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Looks mostly good! Just the hashfuncs change is problematic.
Togira123
force-pushed
the
sync_templates
branch
from
August 5, 2026 09:37
cad4737 to
75d2033
Compare
Ivorforce
reviewed
Aug 6, 2026
Togira123
force-pushed
the
sync_templates
branch
2 times, most recently
from
August 6, 2026 12:18
3b3f067 to
aa9681b
Compare
Togira123
force-pushed
the
sync_templates
branch
from
August 6, 2026 12:21
aa9681b to
f01b6ad
Compare
Ivorforce
approved these changes
Aug 6, 2026
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Looks clean now. Thanks for your effort!
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This syncs a few classes in the templates folder with godot upstream. Done by copy-pasting the code from upstream, then resolving the diffs. It looks like
hashfuncs.cppis the first.cppfile for templates, so had to also edit thegodotcpp.pytool to include it in compilation. Also renamedsort_list.htosort_list.hppto match the other files. I will likely do a bunch more since there are more left but I thought I'd open a PR now since it is already a considerable number of changes.