docs(runtime): correct API routes, CLI flags, and RunConfig fields - #2020
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
68dee30 to
4156e5b
Compare
4156e5b to
ba1ab65
Compare
Technical review reportVerified claims in PR #2020 against Verdict: approve — all ~14 corrections are technically correct, no false claims found. Highest-signal evidence:
Three non-blocking nits (detailed in the artifact): the |
joefernandez
left a comment
There was a problem hiding this comment.
Approved with minor updates.
Audit of the runtime pages (event loop, api server, command line, resume, runconfig, web interface, ambient agents) plus the apps page, where documented HTTP routes, CLI flags, defaults and example code had drifted from the v2.5.0 Python source.
Changes
docs/runtime/ambient-agents.md— the webhook example and thecurlexample both POSTed to/apps/my_agent/run, which is not a route the API server serves; both now POST to/run(the body already carriesapp_name).docs/runtime/command-line.md— the Python option table was missing six real flags (--use_local_storage/--no_use_local_storage,--state,--timeout,--in_memory,--jsonl,--default_llm_model) and did not mention thatadk run <agent> "hello"sends one message and exits instead of starting an interactive session.docs/runtime/web-interface/index.md—--session_service_uriwas documented as defaulting to in-memory; it defaults to SQLite under.adk/session.db. Adds a note that--no_use_local_storageis what falls back to in-memory services.docs/runtime/api-server.md— session delete was documented as returning204 No Contentin Python; Python returns200 OKwith anullbody (TypeScript is the one returning 204).docs/runtime/resume.md— thecurlbody had a trailing comma (invalid JSON);run_asyncwas shown called without being iterated, though it is an async generator; and the resumable-agent example had a commented-out state class, passed the enum instead of the state model to_load_agent_state, and called_create_agent_state_eventwith arguments it does not take — state is now set viactx.set_agent_state(...).docs/runtime/runconfig.md— addsmodel_input_context,history_configandtranslation_config; corrects themax_llm_callslimit to only reject the exact valuesys.maxsize; notessave_input_blobs_as_artifactsis deprecated in Python in favor ofSaveFilesAsArtifactsPlugin.docs/runtime/event-loop.md— the blocking-I/O section claimed the framework prevents stalls for sync tools; Python calls a sync tool inline on the asyncio loop, so it does stall, andRunConfig.tool_thread_pool_configis the live-mode escape hatch. Also fixes theRunnermodule path togoogle.adk.runners.docs/apps/index.md— the list of optionalAppfeatures omittedevents_compaction_config.How this was produced
Part of a page-by-page audit of the Python docs against the
google/adk-pythonv2.5.0 source: every import resolved against a real 2.5.0 install, every constructor kwarg checked againstmodel_fields/inspect.signature, every documented default read off the field. A second independent pass re-derived each claim from source rather than trusting the finding, and a third conformed the new wording to the surrounding pages.mkdocs build --strictis clean.Only Python tabs and language-neutral prose were touched — this audit had no ground truth for the Go / Java / TypeScript SDKs.
Split out of a larger audit branch so each area can be reviewed on its own.
Staged pages: