Skip to content

fix(studio): keep canvas chrome off scaled iframe - #3890

Open
ryansiyglobalcom wants to merge 1 commit into
heygen-com:mainfrom
ryansiyglobalcom:codex/fix-studio-preview-seam
Open

fix(studio): keep canvas chrome off scaled iframe#3890
ryansiyglobalcom wants to merge 1 commit into
heygen-com:mainfrom
ryansiyglobalcom:codex/fix-studio-preview-seam

Conversation

@ryansiyglobalcom

Copy link
Copy Markdown

What

Moves the Studio preview outline and drop shadow from the scaled composition iframe to the outer preview zoom stage. Adds regression coverage for both ownership boundaries.

Why

At fractional fit scales, the iframe box shadow is rasterized on top of composition pixels and appears as a scene-dependent one-pixel edge seam or flicker. Studio chrome should frame the canvas without modifying the composition surface.

How

Removes the shadow-root CSS injection from Player and applies the same visual treatment to preview-zoom-stage, outside the composition iframe. Rendered output and composition code are unchanged.

Test plan

  • Unit tests added/updated
  • Manual testing performed
  • Documentation updated (not applicable: internal editor styling change)

Verification:

  • Full monorepo build
  • Full Studio test suite: 4,838 passed, 18 todo; 438 files passed, 1 skipped
  • Studio typecheck
  • Full repository lint and changed-file format checks
  • Fallow audit against origin/main
  • Browser check at a fractional 1098.65625px preview width: iframe has no box shadow; stage owns the outline/drop shadow; composition edge remains clean

@miguel-heygen

Copy link
Copy Markdown
Collaborator

@ryansiyglobalcom can you attach in the pr description before vs after screenshots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants