Skip to content

fix(runtime): publish progress from parent ticks - #3903

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/player-parent-tick-fresh
Open

fix(runtime): publish progress from parent ticks#3903
miguel-heygen wants to merge 1 commit into
mainfrom
fix/player-parent-tick-fresh

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Keep embedded-player progress updates moving when the iframe's animation frames are throttled.

This retains the verified progress-reporting fix from the stale-PR cleanup. Navigation and reload recovery remain deferred.

Related: #3554

Why

Parent ticks already advance playback, but ordinary ticks do not report the new position to the embedder. Playback can therefore continue while currentTime and timeupdate remain stale.

How

Publish ordinary parent-tick progress through the existing state deduper. Preserve the single forced stopped-state publication at natural end.

Test plan

  • Unit tests added/updated — regression fails without the fix; current runtime initialization suite passes 113/113, with 72/72 adjacent bridge and clock tests.
  • Manual testing performed — real cross-origin browser fixture with child animation frames suppressed verifies progress, stable pause, one natural-end event, and looping.
  • Documentation updated (if applicable) — not applicable.

Full repository commit hooks passed, including core, Studio, and scripts typechecks, Fallow, formatting, linting, artifact guards, and commitlint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant