Repository navigation
Normalize explicit true values for the robots CLI option - #981
Open
Doomguy-BFG9000 wants to merge 1 commit into
Open
Doomguy-BFG9000 wants to merge 1 commit into
Doomguy-BFG9000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http-server --robots truepassed the string"true"through to the server, which treated it as custom robots content. Requests to/robots.txttherefore returnedtruerather than the documented default rules.Normalize that explicit CLI value to boolean
trueafter selecting the short or long option. Custom content strings and the programmatic server API retain their existing behavior.Relevant issues
Fixes #825.
Validation
Windows, Node.js 25.2.1:
-r true,--robots true, and--robots=true; bare flags and custom content controls pass.npm test -- --jobs=2after the fix: 562 assertions pass, 1 skip, 0 failures across the full suite.git diff --checkpasses.Contributor checklist
masterbranch