Fix shard assignment on models with :initialize callbacks - #65
Open
rmsy wants to merge 1 commit into
Open
Conversation
ActiveSupport now aliases _run_initialize_callbacks onto a class whenever it gains its first :initialize callback, and that alias beats the method we prepend onto ActiveRecord::Base. Register a real callback instead. refs AE-4302 Change-Id: I647e8e437ba7efc37a2b842395ea1e405397a684
rmsy
marked this pull request as ready for review
August 4, 2026 00:17
ccutrer
requested changes
Aug 4, 2026
|
|
||
| module Switchman | ||
| VERSION = "4.3.0" | ||
| VERSION = "4.3.1" |
Member
There was a problem hiding this comment.
The lockfiles didn't change with this version bump. Did you run bundle install?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveSupport now aliases
_run_initialize_callbacksonto a class whenever it gains its first :initialize callback, and that alias beats the method we prepend onto ActiveRecord::Base. This registers a real callback instead.