feat: report the negotiated TLS version and cipher - #149
Open
BKPepe wants to merge 1 commit into
Open
Conversation
The debug log already reports the negotiated TLS parameters, but they are missing from the JSON result. The cipher can significantly affect results on hardware without AES acceleration, and TLS 1.3 lets the server select it. Add the negotiated TLS version and cipher to JSON and --json-stream. Omitted for plain HTTP; CSV is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
"tls": {"version", "cipher"}to the JSON report and--json-streamresult.The negotiated cipher can significantly affect results on hardware without AES acceleration, especially with TLS 1.3 where the server selects it.
Omitted for plain HTTP; CSV is unchanged.