feat(storage): restore quarantined archived sessions (phase 2.1 of #42)#558
Open
Wibias wants to merge 3 commits into
Open
feat(storage): restore quarantined archived sessions (phase 2.1 of #42)#558Wibias wants to merge 3 commits into
Wibias wants to merge 3 commits into
Conversation
…dge-jun#42) Add trash list/restore APIs, Storage GUI quarantine panel, and round-trip tests so default cleanup can be undone without Phase 3 purge.
This comment was marked as outdated.
This comment was marked as outdated.
… races Keep satellite backups for quarantine restore, snapshot full thread rows and state dependents, remap satellite DB paths, and make satellite failures retryable. Drop duplicate trash probing so Storage abort/generation ownership stays correct.
Use link+unlink no-replace for trash restore so a raced dest cannot be overwritten, and raise timeouts for multi-satellite cleanup tests that overrun 5s on Windows CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/storage/trashandPOST /api/storage/trash/restoreto list and restore Phase 2 quarantine entries underCODEX_HOME/.trash/<epoch>/(relative paths only).satellite-backup.jsonis present), removes the trash entry on success, and returns 409 when Codex DBs are busy.Closes part of #42 (Phase 2.1 only — no Phase 3 auto-policy/purge).
Test plan
bun test --isolateforstorage-cleanup,api-storage-cleanup,api-storage,storage-scannerbun run typecheckstate_*.sqlite, confirm restore returns busy / 409Summary by CodeRabbit
New Features
Bug Fixes
Documentation