[Intel] Add a means to check which intel gpu generation for vulkan and directX#1291
[Intel] Add a means to check which intel gpu generation for vulkan and directX#1291farzonl wants to merge 5 commits into
Conversation
farzonl
force-pushed
the
intel_gpu_generation_check
branch
3 times, most recently
from
a76e60a to
f302140
Compare
| case 0x7D00: // Meteor Lake (14th Gen Core Ultra) | ||
| case 0x5600: // Arc Alchemist (Discrete Xe-HPG) | ||
| case 0x4F00: // DG1 (Discrete Xe-LP) | ||
| case 0x0B00: // Ponte Vecchio (Xe-HPC / Data Center Max) |
There was a problem hiding this comment.
I don't know what the family prefix is for Battlemage, so this is unlikely to work on CI. will need help figuring this out.
There was a problem hiding this comment.
I guess based on these docs BattleImage would be E2
There was a problem hiding this comment.
| case 0x0B00: // Ponte Vecchio (Xe-HPC / Data Center Max) | |
| case 0x0B00: // Ponte Vecchio (Xe-HPC / Data Center Max) | |
| case 0xE200: // Battlemage Discrete | |
| case 0x6400: // Lunar Lake Integrated |
farzonl
force-pushed
the
intel_gpu_generation_check
branch
from
f302140 to
cd0826f
Compare
| if device["GPUGeneration"] == "Intel Gen11-14/Xe": | ||
| config.available_features.add("Intel-Modern-GPU") | ||
| if device["GPUGeneration"] == "Intel Gen7-10": | ||
| config.available_features.add("Intel-Legacy-GPU") |
There was a problem hiding this comment.
I feel like these names might bite us at some point in the future. Should we bikeshed them a little?
There was a problem hiding this comment.
sure bikeshed away. I just want a tag to xfail on.
There was a problem hiding this comment.
@V-FEXrt suggested backwards looking ranges, so Intel-Gen-10 instead of Intel-Legacy-GPU and Intel-Gen-X or Intel-Gen-Current for the "modern" one. This also allows, for example, Intel-Gen-6 if we needed older GPUS (we won't...) and makes it fairly obvious how to update this if another generation pops up.
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
LGTM. I'll let you use your discretion on the naming, and obviously we should wait for the intel bots to clear.
farzonl
force-pushed
the
intel_gpu_generation_check
branch
2 times, most recently
from
405afee to
5842b29
Compare
…. updte test cases for updated xfail
farzonl
force-pushed
the
intel_gpu_generation_check
branch
from
5842b29 to
881f4ab
Compare
2 participants
This change fixes #709