Skip to content

Fix X1 charge status LED always showing charged - #3124

Closed
Hacuchino-hash wants to merge 1 commit into
meshcore-dev:devfrom
Hacuchino-hash:fix-x1-charge-status
Closed

Fix X1 charge status LED always showing charged#3124
Hacuchino-hash wants to merge 1 commit into
meshcore-dev:devfrom
Hacuchino-hash:fix-x1-charge-status

Conversation

@Hacuchino-hash

@Hacuchino-hash Hacuchino-hash commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow up to #3122, correcting the charge complete handling on the MeshTracker X1.

The charging indication itself works, the LED shows the charging animation while power is applied. What is wrong is the charge complete branch: it gives priority to the charger's second status line (P1.4) as a "done" signal, and on this board that pin reads low regardless of charge state, so the complete branch always wins and the LED sits on the charged colour.

Charge state now comes from P1.3 alone, which behaves correctly (low while charging, high once charging stops). P1.4 is left unused with a comment explaining why, the same choice Meshtastic makes in their X1 variant where the equivalent define is commented out.

Testing

Measured on hardware at partial charge (4.15 V, actively charging): P1.3 reads low as expected, and P1.4 also reads low, which is what sends it down the wrong branch. With this change the LED correctly shows the charging animation at that state. All four X1 environments build clean.

@Hacuchino-hash

Copy link
Copy Markdown
Contributor Author

Closing this for now. The charge complete state needs more work than this change covers: on this board neither charger status line gives a usable done signal, so the charged state is still not reachable. I will retest properly on hardware and open a complete fix.

@Hacuchino-hash
Hacuchino-hash deleted the fix-x1-charge-status branch August 7, 2026 14:34
@Hacuchino-hash
Hacuchino-hash restored the fix-x1-charge-status branch August 7, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant