Fix missing header for UWP build - #1348
Conversation
|
Darn -- just too late for v3.4.4 but it'll be in the next one :-) It is strange to include bcrypt.h just for |
|
I think After all, since mimalloc uses BCryptGenRandom is not bad idea include the header for Windows. |
|
Ah I see; let me think a bit on this as mimalloc is still used on older platforms and we need to make sure bcrypt.h is available there. Maybe we should just define NTSTATUS if it isn't defined yet. |
This is an alternative, but it should work from Windows Vista onwards... |
|
Oh! seems this is already fixed in dev branch: mimalloc/src/prim/windows/prim.c Line 54 in 9ce8170 So this PR isn't needed here. |
Follow-up of #1340
This header is necessary to build for UWP because
NTSTATUSis not defined in<winternl.h>(for WINAPI_PARTITION_APP).Not noticed before because in my private UWP patch Bcrypt is not dynamically loaded and bcrypt.h was already present.
I have now tested this exact PR and Bcrypt works with dynamic loading on UWP.
Header is need only for
NTSTATUSdefinition.