feat: expose protocol version negotiation to server handlers - #1247
Open
DaleSeo wants to merge 1 commit into
Open
feat: expose protocol version negotiation to server handlers#1247DaleSeo wants to merge 1 commit into
DaleSeo wants to merge 1 commit into
Conversation
github-actions
Bot
added
T-test
DaleSeo
marked this pull request as ready for review
September 6, 2026 09:26
DaleSeo
force-pushed
the
DaleSeo/negotiate-initialize
branch
from
September 6, 2026 09:30
8c516c4 to
4940bc9
Compare
DaleSeo
force-pushed
the
DaleSeo/negotiate-initialize
branch
from
September 6, 2026 10:21
4940bc9 to
ca4564a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1245.
Motivation and Context
The negotiation logic lives in a
pub(crate)function and in a default method generated by a macro, so an override cannot access it. Servers that overrideinitializefor telemetry or peer registration have to duplicate the rule, which can silently get out of sync when the SDK rule changes.This PR adds
ServerHandler::negotiate_initialize, so servers that overrideinitializecan reuse the SDK's protocol version negotiation instead of implementing it again.How Has This Been Tested?
Add tests
Breaking Changes
None.
Types of changes
Checklist