PYTHON-5784 Coverage increase for periodic_executor.py#2771
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5784
Changes in this PR
Adds
test/asynchronous/test_periodic_executor.py(synchro'd totest/test_periodic_executor.py) with unit tests forpymongo/periodic_executor.py, covering bothPeriodicExecutorandAsyncPeriodicExecutor:join()beforeopen()is a safe no-op.Falsestops the executor.skip_sleep()causes the next iteration to run without waiting the full interval.wake()interrupts the current sleep and triggers an early run.open()after the target returnedFalserestarts the executor.Test Plan
Added unit tests using
asyncio.Event/threading.Eventfor deterministic synchronization. The exception test swapsthreading.excepthookto a no-op so the intentionalRuntimeErrorin the worker thread is not surfaced by pytest's threadexception plugin (no-op for the async executor since no thread is involved).Checklist
Checklist for Author
Checklist for Reviewer