Skip to content

fix(e2ee): refresh during crud operations#17267

Open
alperozturk96 wants to merge 18 commits into
masterfrom
fix/e2ee-counter-check
Open

fix(e2ee): refresh during crud operations#17267
alperozturk96 wants to merge 18 commits into
masterfrom
fix/e2ee-counter-check

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue

Refreshing folder causing crash during crud operations in encrypted folder. Local counter should be only updated after completion of operation.

Changes

  • Consolidates counter updates
  • Updates counter after serializeAndUploadMetadata and unlock folder
  • Better naming

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jul 1, 2026
alperozturk96
alperozturk96 commented Jul 1, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/utils/EncryptionUtilsV2.kt
alperozturk96
alperozturk96 commented Jul 1, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/utils/EncryptionUtilsV2.kt
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28519645539/artifacts/8011646161
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the fix/e2ee-counter-check branch from a68af81 to 9be910e Compare July 9, 2026 08:16
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29005173465/artifacts/8193741488
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky
tobiasKaminsky requested changes Jul 15, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/operations/RefreshFolderOperation.java Outdated
@alperozturk96
alperozturk96 force-pushed the fix/e2ee-counter-check branch from 217f1b1 to 6e52bf6 Compare July 17, 2026 11:12
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29577078416/artifacts/8405696732
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29578868607/artifacts/8406318076
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29581557894/artifacts/8407647313
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17267-IT-master-15-24

@alperozturk96
alperozturk96 force-pushed the fix/e2ee-counter-check branch from 36da01e to 4bd9257 Compare July 23, 2026 06:13
@alperozturk96
fix(e2ee): refresh during crud operations
ce3789d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
consolidate usages
1ad25f0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java
@alperozturk96
improve naming
0ef585e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wait until current uploads finish then verify metadata
45b7f4b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
d8b5784 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
3435957 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
2bc2343 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
b9e009e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
0ec465a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
a1b66e0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
485b63f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
ef06cfa 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
1b791c7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
ac8d820 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
7d9298e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix remove counter update
c19e440 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix create folder counter update
ca65280 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better naming
29fc39c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/e2ee-counter-check branch from 73f4e67 to 29fc39c Compare July 23, 2026 09:43
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review E2E

Projects

None yet

Milestone

Nextcloud App 34.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky