feat: NC governance - #4152
Merged
Merged
Conversation
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
…ernance Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
mpivchev
marked this pull request as ready for review
July 22, 2026 14:14
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds Nextcloud governance support in Share “Details”, migrating the share paging UI from Parchment to a SwiftUI-based segmented/tab layout.
Changes:
- Introduces a new “Details” tab and SwiftUI screens to view/apply governance labels (sensitivity/retention/legal hold).
- Replaces Parchment paging in share details with a SwiftUI
Picker+TabViewand updates related UI backgrounds. - Adjusts metadata permission checks to require move permission for move/delete behaviors.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| iOSClient/Supporting Files/en.lproj/Localizable.strings | Adds governance-related localized strings. |
| iOSClient/Share/NCSharePaging.swift | Replaces Parchment paging with SwiftUI segmented picker + paged TabView; adds Details tab wiring. |
| iOSClient/Share/NCShareHeader.xib | Updates TagListView layout priorities and background. |
| iOSClient/Share/NCShareHeader.swift | Ensures tag list view is transparent. |
| iOSClient/Share/NCShareDetailsView.swift | Adds SwiftUI “Details” governance form and hosting controller. |
| iOSClient/Share/NCShareDetailsGovernanceModel.swift | Adds governance data loading + saving model backed by NextcloudKit. |
| iOSClient/Share/NCShare.swift | Updates share UI background colors; removes Parchment import. |
| iOSClient/Share/NCMetadataPermissions.swift | Adds canMoveAndDelete helper and doc updates. |
| iOSClient/Share/NCGovernanceLabelSelectorView.swift | Adds reusable governance label selection sheet + color parsing helper. |
| iOSClient/Main/Create/NCCreate.swift | Hides Details tab when governance is disabled in capabilities. |
| iOSClient/Data/NCManageDatabase+Metadata.swift | Tightens move/delete UI eligibility based on permissions. |
| iOSClient/Activity/NCActivityCommentView.xib | Adjusts background colors for comment input view. |
| iOSClient/Activity/NCActivity.swift | Adds grouped background option + updates section header styling. |
| iOSClient/Activity/NCActivity.storyboard | Adjusts cell background color. |
| Nextcloud.xcodeproj/project.pbxproj | Removes Parchment; switches NextcloudKit dependency to a local package reference; adds new Swift files to build. |
| Brand/NCBrand.swift | Adds .details to Info Paging tabs enum. |
| .gitignore | Ignores .claude/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Build fails because NCKit points to main, not the PR branch. Should be green when NCKit PR is merged |
marinofaggiana
marked this pull request as draft
July 23, 2026 06:21
marinofaggiana
marked this pull request as ready for review
July 23, 2026 06:21
marinofaggiana
approved these changes
Jul 23, 2026
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
mpivchev
enabled auto-merge (squash)
July 23, 2026 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCKit: nextcloud/NextcloudKit#237